Skip to content

MM2-1658 Fix: display error message from api in create commision rule form #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: testing
Choose a base branch
from
Open

MM2-1658 Fix: display error message from api in create commision rule form #19

wants to merge 2 commits into from
+596 −355

Conversation

@sylwia-werner
Copy link
Collaborator

@sylwia-werner sylwia-werner commented Nov 12, 2025 •
edited
Loading

  • Add api and client side validation + display the messages
  • Refactor: use modern approach with react hook form, zod validation
  • Fix not being able to scroll vertically inside the modal
  • Fix styling

@vercel
Copy link

vercel bot commented Nov 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
admin-panel Ready Ready Preview Comment Nov 12, 2025 4:01pm
mercuradmin-development Ready Ready Preview Comment Nov 12, 2025 4:01pm
test-admin-panel Ready Ready Preview Comment Nov 12, 2025 4:01pm

@sylwia-werner
refactor: create commision rule form, fix not being able to scroll in…
268f5cc 
…side modal, add correct labels and validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikolvj mikolvj Awaiting requested review from mikolvj

@kacpergumieniuk kacpergumieniuk Awaiting requested review from kacpergumieniuk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sylwia-werner